fix: memory leak in storageMainService#317841
Open
SimonSiefke wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the Electron main-process storage lifecycle to proactively close profile/workspace storages when a window closes, and adjusts how storages are instantiated and tracked.
Changes:
- Add window close/destroy hook to close associated profile/workspace storages.
- Introduce
toWorkspaceIdentifierusage to derive a workspace identifier for closing. - Stop registering created profile/workspace storage instances with
_register().
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in storageMainService.
Details
In
storageMainService, when a window is loaded, the profile storage and workspace storage for that window are intialized:But it seems the profile storage and workspace storage aren't being closed their window closes.
Changes
The change ensures when a window is closed, that its profile storage and workspace storage are closed as well:
Also this code
is changed to
because adding the storage disposables via
this._registerwould only remove them when thestorageMainServiceshuts down. instead of when the window closes.Before
When opening and closing a new window 17 times, the number of storageMainService functions seems to grow each time:

After
When opening and closing a new window 17 times, the number of storageMainService function stays constant: